[zephyr] Fix factory recent after recent KVS changes #20419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to update the factory reset routine after adding escaping of forbidden characters in KVS keys and the routine is escaping such keys twice which results in a failure. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
pullapprove
bot
requested review from
lazarkov,
yunhanw-google,
LuDuda,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #20419: Size comparison from 1107d8e to 7532ad4 Increases (15 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
Decreases (1 build for cc13x2_26x2)
Full report (38 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Jul 7, 2022
andy31415
approved these changes
Jul 7, 2022
|
@andy31415 could we fast-track this platform bugfix? |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
I forgot to update the factory reset routine after adding escaping of forbidden characters in KVS keys and the routine is escaping such keys twice which results in a failure. Signed-off-by: Damian Krolik <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Jul 12, 2022
I forgot to update the factory reset routine after adding escaping of forbidden characters in KVS keys and the routine is escaping such keys twice which results in a failure. Signed-off-by: Damian Krolik <[email protected]> Co-authored-by: Damian Królik <[email protected]>
ajwak
pushed a commit
to ajwak/connectedhomeip
that referenced
this pull request
Jul 13, 2022
) I forgot to update the factory reset routine after adding escaping of forbidden characters in KVS keys and the routine is escaping such keys twice which results in a failure. Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I forgot to update the factory reset routine after adding escaping of forbidden characters in KVS keys and the routine is escaping such keys twice which results in a failure.
Change overview
Use Zephyr's
settings_deletecall directly in the callback from Zephyr setting enumeration function.Testing
Enhanced unit tests to test the factory reset with escaped keys.
Tested manually on nRF 52840, too.